[Mailer] Better explain the load-balancing options #12301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @weaverryan if you can, please review this. I'm not sure my wording is perfectly clear here. Thanks a lot! |
|
I think you miss the latest change about „failover()“ and „roundrobin()“ here, which was merged in another PR yesterday? Today? I am currently on a phone 📱 |
|
@OskarStark you are right ... but that change was made in 4.4 (as a BC break, but that's OK because it's still experimental). This one improves the explanation from 4.3, which is when this was introduced. |
|
You are right 👍🏻 |
javiereguiluz
force-pushed
the
mailer_load_balancing
branch
from
5c041b1 to
bc668cc
Compare
fabpot
reviewed
Sep 16, 2019
javiereguiluz
added a commit
that referenced
this pull request
Sep 17, 2019
…guiluz) This PR was merged into the 4.3 branch. Discussion ---------- Fixed some explanations in the mailer component This fixes some mistakes introduced in #12301 because "failover" is not a "load balancing" technique but a "high availability" one. Commits ------- 27e46a7 Fixed some explanations in the mailer component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.